Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint issues in pkg/kubelet/types #97374

Merged
merged 1 commit into from Jan 6, 2021
Merged

Fix golint issues in pkg/kubelet/types #97374

merged 1 commit into from Jan 6, 2021

Conversation

geegeea
Copy link
Contributor

@geegeea geegeea commented Dec 17, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR fixes golint issues in pkg/kubelet/types

Which issue(s) this PR fixes:
Part of #68026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

@geegeea: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @geegeea. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 17, 2020
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 17, 2020
@hwdef
Copy link
Member

hwdef commented Dec 18, 2020 •
edited

/ok-to-test
/release-note-none

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 18, 2020
@hwdef
Copy link
Member

hwdef commented Dec 18, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 18, 2020
@ehashman
Copy link
Member

/lgtm
/priority backlog

Mostly docstring updates, no real semantic changes

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 21, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2020
@geegeea
Copy link
Contributor Author

geegeea commented Dec 22, 2020

/assign @vishh

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Dec 23, 2020
Closed
SergeyKanzhelev
SergeyKanzhelev reviewed Dec 23, 2020
View reviewed changes
pkg/kubelet/types/pod_update.go Outdated
ADD
// Pods with the given ids are gracefully deleted from this source
// DELETE: Pods with the given ids are gracefully deleted from this source.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like how you approached it with adding semicolon. Would love to see more human readable thing. But it's fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the comments to be more human readable. Please take a look.

@SergeyKanzhelev
Copy link
Member

(for /hack):
/assign @dims

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2020
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Dec 24, 2020 •
edited

@geegeea please squash commits.

@geegeea geegeea force-pushed the golint branch 3 times, most recently from 7a96e84 to 4942669 Compare December 24, 2020 02:59
@k8s-ci-robot k8s-ci-robot added area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 24, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 24, 2020 •
edited

@geegeea: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-conformance-kind-ipv6-parallel 494266967b6470df94c701b01723487b42877e8e link /test pull-kubernetes-conformance-kind-ipv6-parallel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geegeea
Copy link
Contributor Author

geegeea commented Dec 24, 2020

Gurleen Grewal please squash commits.

@SergeyKanzhelev done rebase.

@dims
Copy link
Member

dims commented Dec 25, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 25, 2020
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Dec 29, 2020
Closed
@geegeea
Copy link
Contributor Author

geegeea commented Dec 30, 2020

/assign @vishh

@dims
Copy link
Member

dims commented Jan 4, 2021

/assign @mrunalp @derekwaynecarr

@mrunalp
Copy link
Contributor

mrunalp commented Jan 5, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, geegeea, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit b39494c into kubernetes:master Jan 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 6, 2021
@ehashman ehashman mentioned this pull request Jan 13, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@dims dims

@mrunalp mrunalp

@ehashman ehashman

@derekwaynecarr derekwaynecarr

@vishh vishh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Triage
SIG Node CI/Test Board
Archived in project
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@geegeea @k8s-ci-robot @hwdef @ehashman @SergeyKanzhelev @dims @mrunalp @derekwaynecarr @vishh